-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds find_package for fmtlib, range-v3, nlohmann_json #15878
base: develop
Are you sure you want to change the base?
Conversation
hmm.. I just saw this - the question is basically how the stuff is used.. the use-case that I had in mind when I was doing this, was to just being able to easily embed solidity into another project - where the "root" cmake file will find needed packages.. I'm not sure right now why I exactly not just added the find_packages there - but maybe we should at least have a mechanism that will not call find the needed packages automatically - so that the "root" cmake file is still under control |
However, I don't see the reason right now why I didn't just call |
Ok, I just remembered the issue, why I decided not to use |
The only thing that could make some sense for some users is to allow them to ignore specific versions of the libraries. E.g. by default we use exactly what you have defined, but if e.g. something like |
Indeed, having specific versions will break packages like https://aur.archlinux.org/packages/solidity. |
For this particular package I don't see how this change would lead to breakage. It has |
The reason that I am the package maintainer. |
Adds find_package for fmtlib, range-v3, nlohmann_json if
IGNORE_VENDORED_DEPENDENCIES
was set toON
.Fixes #15872