Fix Typographical Errors in Solidity Test Files #15873
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
|
The changes themselves look ok, but if you're just fixing typos, please avoid unnecessarily spreading that over multiple PRs. I see you already submitted #15757 not long ago. I'll keep this one open for now in case you find something more you'd like to add. I mean that's just 2 PRs from you specifically, but we're currently getting flooded with tons of small PRs that fix exactly 3 typos and stop, which looks like people are intentionally splitting them, making it more work to review them. This is unnecessarily drawing our attention from more important changes. We're generally fine merging even very small fixes as long as they are obviously correct, but if there are changes needed, we unfortunately can't spend too much time on reviewing them. Which is why e.g. your #15758 was stuck in limbo. |
updated, check please |
There was a problem hiding this comment.
The PR seems to add 3 new tests now. Was it meant to be a rename? If so, you probably forgot to commit the removal of the file with the old name.
|
Please also squash your commits a bit. Our convention is to have one logical change per commit and IMO fixing all those typos would be just one change. I'd only make sense create a separate commit for a specific typo if it was very widespread of if fixing it required some adjustments elsewhere and those would have to be grouped. |
Got it, I'll keep that in mind. All checks have passed. Is this enough? |
|
#15873 (comment) is still unaddressed. |
Since SMTChecker now uses SMT-LIB to represent the queries and pass them to the solvers, we do not have to restrict this option to the "smtlib2" solver. It can be used with any solver. The query will be logged and then passed to the solver as usual.
Previously, if a fatal error would occur during constant evaluation in the model checker, it would throw an exception which the model checker would let escape and crash the compiler. We now use the new API that swallows any errors and the model checker can continue, simply treating the expression as not constant.
corrected |
What do you mean? I see you merged Also, the branch needs a rebase on |
Description:
This pull request addresses several typographical errors in the Solidity test files. The following changes have been made:
modifer_recursive.soltomodifier_recursive.solto correct the spelling ofmodifierno_target_for_abstract_constract.soltono_target_for_abstract_contract.solto fix the spelling ofcontract142_inheritence_suggestions.solto142_inheritance_suggestions.solto correct the spelling ofinheritanceThese changes improve the clarity and accuracy of the test files.
Please review the changes and let me know if any further modifications are needed. Thank you!