SMTChecker: Ignore errors that might occur during constant evaluation #15863
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
force-pushed
the
smt-fix-constant-evaluation
branch
from
cd282f8 to
7c3878c
Compare
This was
linked to
issues
Feb 14, 2025
cameel
previously approved these changes
Feb 14, 2025
libsolidity/formal/SMTEncoder.cpp
Outdated
| ErrorList l; | ||
| ErrorReporter e(l); | ||
| if (auto t = ConstantEvaluator::evaluate(e, _expr)) | ||
| if (auto t = ConstantEvaluator::tryEvaluate(_expr)) |
There was a problem hiding this comment.
Now that we have the helper, we should use it in StaticAnalyzer::visit(BinaryOperation) as well. Though that needs a changelog entry and some tests so maybe it's better off done in a separate PR.
There was a problem hiding this comment.
Yes, I think this should be done in a separate PR.
blishko
force-pushed
the
smt-fix-constant-evaluation
branch
2 times, most recently
from
f824f3b to
cb5d6a5
Compare
cameel
previously approved these changes
Feb 17, 2025
blishko
force-pushed
the
smt-fix-constant-evaluation
branch
from
cb5d6a5 to
74b9c33
Compare
Previously, if a fatal error would occur during constant evaluation in the model checker, it would throw an exception which the model checker would let escape and crash the compiler. We now use the new API that swallows any errors and the model checker can continue, simply treating the expression as not constant.
blishko
force-pushed
the
smt-fix-constant-evaluation
branch
from
74b9c33 to
de36f55
Compare
cameel
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a fatal error would occur during constant evaluation in the model checker, it would throw an exception which the model checker would let escape and crash the compiler.
We introduce a new API to
ConstantEvaluatorthat swallows any errors use it from the model checker.This allows model checker to continue, treating any expression where an error would occur simply as not constant.
Fixes #15600 #15601 #15722.
Resolves point 3 of @cameel 's analysis in #15709.