Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs & CSS: Minor Grammar Fixes and Toggle Alignment Improvements #15787

Closed
wants to merge 3 commits into from

Conversation

MarsonKotovi4
Copy link

@MarsonKotovi4 MarsonKotovi4 commented Jan 28, 2025

PR Description

  • Summary of Changes

    • toggle.css: Changed align-items: right to align-items: flex-end for clearer label alignment.
    • abstract-contracts.rst: Corrected grammar (“can not” → “cannot”) to clarify abstract contract instantiation rules.
    • errors.rst: Tweaked phrasing about errors indistinguishable by the ABI for improved readability.
  • Issue Reference

    • No related issue. This PR was created from scratch and does not close or fix any specific issue.
  • Breaking Changes

    • This PR introduces no breaking changes and is branched off develop.
  • Dependencies

    • None.
  • Tests & Documentation

    • No code behavior changes, so no new tests were added.
    • Only documentation and CSS updates were made.
    • No updates required for existing test expectations.
  • Additional Notes

    • Branch name: improve-toggle-css-and-docs (example).
    • This PR is my only open PR, so it aligns with the requirement of working on just one at a time.
    • Since the changes are non-breaking and purely aesthetic/documentation-related, no changelog entry is required.

Checklist:

  • No other open PRs.
  • Not a breaking change.
  • No issue to reference (Fixes #...) because this PR is a standalone improvement.
  • No dependencies on other PRs.
  • Documentation changes are small clarifications; tests remain unaffected.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@MarsonKotovi4 MarsonKotovi4 changed the title Docs & CSS: Improve toggle alignment and refine contract docs Docs & CSS: Minor Grammar Fixes and Toggle Alignment Improvements Jan 28, 2025
@nikola-matic
Copy link
Collaborator

I'll be closing this PR since none of the changes seem to fix or improve much of anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants