Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "External accounts" with "Externally-owned accounts" for accuracy #15774

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

codersjj
Copy link

Correct terminology to align with Ethereum's official documentation.
In addition, this is also consistent with the content on Wikipedia.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a total of four instances of 'external accounts', whereas you've only changed one.

introduction-to-smart-contracts.rst:of a keypair belonging to :ref:`external accounts<accounts>`.
introduction-to-smart-contracts.rst:address space: **External accounts** that are controlled by
introduction-to-smart-contracts.rst:The address of an external account is determined from
security-considerations.rst:- Neither contracts nor "external accounts" are currently able to prevent someone from sending them Ether.

@codersjj
Copy link
Author

codersjj commented Feb 1, 2025

There are a total of four instances of 'external accounts', whereas you've only changed one.

introduction-to-smart-contracts.rst:of a keypair belonging to :ref:`external accounts<accounts>`.
introduction-to-smart-contracts.rst:address space: **External accounts** that are controlled by
introduction-to-smart-contracts.rst:The address of an external account is determined from
security-considerations.rst:- Neither contracts nor "external accounts" are currently able to prevent someone from sending them Ether.

You're right! I missed the other instances. I'll update all four. Thanks! 🙌

@codersjj codersjj requested a review from nikola-matic February 1, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants