Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic and syntax test dir names not following the same naming convention #15766

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

cameel
Copy link
Member

@cameel cameel commented Jan 23, 2025

Related to #15765.

Since I was already moving/renaming a lot of tests I thought I can just as well take care of this irregularity. We generally use camel case for test dir names. There were a few dirs that were not following this convention.

Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should semanticTests/abiencodedecode be semanticTests/abiEncodeDecode?

@cameel cameel force-pushed the fix-test-dirs-not-following-naming-convention branch from 89fc3d9 to 520903a Compare January 23, 2025 21:04
@cameel
Copy link
Member Author

cameel commented Jan 23, 2025

Good point. Added to the PR.

@cameel cameel force-pushed the fix-test-dirs-not-following-naming-convention branch from 520903a to 6854a62 Compare January 23, 2025 21:05
@nikola-matic nikola-matic merged commit 0b1b902 into develop Jan 23, 2025
75 checks passed
@nikola-matic nikola-matic deleted the fix-test-dirs-not-following-naming-convention branch January 23, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants