Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Semantic tests fixes for EOF #15619

Closed
wants to merge 22 commits into from
Closed

[DO NOT MERGE] Semantic tests fixes for EOF #15619

wants to merge 22 commits into from

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Dec 6, 2024

Semantic tests fixes. It's going to be splitted to separated PRs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel cameel added the EOF label Dec 6, 2024
@cameel cameel changed the title [DO NOT MERGE] Semantic tests fixes. [DO NOT MERGE] Semantic tests fixes for EOF Dec 6, 2024
@rodiazet rodiazet force-pushed the eof-semantic-tests-update branch 17 times, most recently from 658f91a to 2388c52 Compare December 13, 2024 13:26
@rodiazet rodiazet force-pushed the eof-semantic-tests-update branch 6 times, most recently from d3a0af3 to 5d55a9a Compare December 16, 2024 12:13
cameel
cameel reviewed Dec 16, 2024
View reviewed changes
test/TestCase.cpp
@@ -146,7 +146,7 @@ void EVMVersionRestrictedTestCase::processBytecodeFormatSetting()
// EOF only available since Prague
solAssert(!eofVersion.has_value() ||solidity::test::CommonOptions::get().evmVersion() >= langutil::EVMVersion::prague());

std::string bytecodeFormatString = m_reader.stringSetting("bytecodeFormat", "legacy");
std::string bytecodeFormatString = m_reader.stringSetting("bytecodeFormat", "legacy,>=EOFv1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing we need here to make sure tests are actually running on EOF is to clear the blacklist we added to soltest.sh in #15552:

solidity/.circleci/soltest.sh

Lines 46 to 75 in 03e2739

# TODO: [EOF] These won't pass on EOF yet. Reenable them when the implementation is complete.
EOF_EXCLUDES=(
--run_test='!Assembler/all_assembly_items'
--run_test='!Assembler/immutable'
--run_test='!Assembler/immutables_and_its_source_maps'
--run_test='!Optimiser/jumpdest_removal_subassemblies'
--run_test='!Optimiser/jumpdest_removal_subassemblies/*'
--run_test='!SolidityCompiler/does_not_include_creation_time_only_internal_functions'
--run_test='!SolidityInlineAssembly/Analysis/create2'
--run_test='!SolidityInlineAssembly/Analysis/inline_assembly_shadowed_instruction_declaration'
--run_test='!SolidityInlineAssembly/Analysis/large_constant'
--run_test='!SolidityInlineAssembly/Analysis/staticcall'
--run_test='!ViewPureChecker/assembly_staticcall'
--run_test='!functionSideEffects/otherImmovables'
--run_test='!functionSideEffects/state'
--run_test='!functionSideEffects/storage'
--run_test='!gasTests/abiv2'
--run_test='!gasTests/abiv2_optimised'
--run_test='!gasTests/data_storage'
--run_test='!gasTests/dispatch_large'
--run_test='!gasTests/dispatch_large_optimised'
--run_test='!gasTests/dispatch_medium'
--run_test='!gasTests/dispatch_medium_optimised'
--run_test='!gasTests/dispatch_small'
--run_test='!gasTests/dispatch_small_optimised'
--run_test='!gasTests/exp'
--run_test='!gasTests/exp_optimized'
--run_test='!gasTests/storage_costs'
--run_test='!yulStackLayout/literal_loop'
)

@rodiazet rodiazet force-pushed the eof-semantic-tests-update branch 2 times, most recently from accb2a0 to 521cd46 Compare December 16, 2024 20:35
@rodiazet rodiazet force-pushed the eof-semantic-tests-update branch 2 times, most recently from f6d5404 to 706e24f Compare December 18, 2024 14:51
@rodiazet
Enable default test running for EOF
de59329
@rodiazet
eof: Add test which checks that setting an EOF version results in the…
7f9e573 
… experimental flag being set.
@rodiazet
eof: Update semanticTests tests for EOF
6868499
@rodiazet
eof: Update yulOptimizerTests tests for EOF
7795883
@rodiazet
eof: Update yulSyntaxTests tests for EOF
5d44d3b
@rodiazet
eof: objectCompiler tests updating
6d13c3b
@rodiazet
eof: Enable yul in SyntaxTest by default when compiling to EOF
f341923
@rodiazet
eof: Update syntax tests + disabling tests which does not make sense …
6638bd1 
…for EOF
@rodiazet
eof: Update semantic tests - removing address from test expectation
708aa5a
@rodiazet
eof: TODO: Fix adding metadata to the code in EOF
d1de8d9
@rodiazet
eof: TODO: EOF for non-optimized yul compilation.
8367ca6
@rodiazet
eof: TODO: Fix returning two errors for EOF
8f52dce
@rodiazet
eof: TODO: Cannot test address in events
b1c2efa
@rodiazet
eof: TODO: Fix lack of error when accessing unassigned immutable.
ce0f2e8
@rodiazet
eof: Disable smtCheckeTests when compiling to EOF.
0b85a49
@rodiazet
eof: Update yulOptimizerTests tests.
0efcc7c
@rodiazet
eof: Update yulControlFlowGraph tests
6b9c280
@rodiazet
eof: Update yulStackLayout tests
52f8379
@rodiazet
eof: Update yulInterpreterTests tests
eb8941a
@rodiazet
eof: Enable disables earlier tests.
4316bad
@rodiazet
eof: Update C++ tests
0370606
@rodiazet
eof: Fix errors for instructions deplacated by EOF
290a6bd
@rodiazet rodiazet force-pushed the eof-semantic-tests-update branch from 706e24f to 290a6bd Compare December 19, 2024 09:01
@rodiazet
Copy link
Contributor Author

Splitted into many separated PRs

@rodiazet rodiazet closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel left review comments

Assignees
No one assigned
Labels
EOF external contribution ⭐
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodiazet @cameel