Testing code generation errors #15612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
added
testing 🔨
has dependencies
cameel
commented
Dec 4, 2024
Comment on lines
+1559
to
+1651
| throw Error( | ||
| 2202_error, | ||
| Error::Type::CodeGenerationError, | ||
| "Code section too large for EOF." | ||
| ); |
There was a problem hiding this comment.
@rodiazet Once this PR gets merged, this is how EOF errors triggerable by user code should be reported.
The analyzer checks for the number of subs and functions should be replaced with this.
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
2 times, most recently
from
0abfe3a to
812efab
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
13b4f30 to
126b33f
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
812efab to
609fd43
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
2 times, most recently
from
6cab972 to
0d31dde
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
609fd43 to
4d3140e
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
0d31dde to
dce96ab
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
2 times, most recently
from
48fd3d0 to
29c2a39
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
dce96ab to
24dcbc6
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
29c2a39 to
f1e44cf
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
24dcbc6 to
336001a
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
2 times, most recently
from
e797b3c to
fcbfbf5
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
336001a to
0ae3cef
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
fcbfbf5 to
9acd665
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
0ae3cef to
f59e518
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
9acd665 to
3d8ff6b
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
f59e518 to
81e56aa
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
3d8ff6b to
2f4d58f
Compare
cameel
force-pushed
the
unify-yul-parsing-across-test-suites
branch
from
2f4d58f to
46b0616
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
from
81e56aa to
ef2a623
Compare
Base automatically changed from
unify-yul-parsing-across-test-suites
to
develop
December 17, 2024 15:42
cameel
force-pushed
the
testing-code-generation-errors
branch
from
ef2a623 to
c6179ea
Compare
cameel
removed
the
has dependencies
matheusaaguiar
previously approved these changes
Dec 18, 2024
cameel
force-pushed
the
testing-code-generation-errors
branch
2 times, most recently
from
1b82389 to
ba35d52
Compare
cameel
added
the
has dependencies
cameel
changed the base branch from
develop
to
fix-eof-data-section-size-validation
cameel
force-pushed
the
fix-eof-data-section-size-validation
branch
from
2115f2a to
c158522
Compare
cameel
force-pushed
the
testing-code-generation-errors
branch
2 times, most recently
from
d5ff624 to
3966f44
Compare
cameel
force-pushed
the
fix-eof-data-section-size-validation
branch
from
c158522 to
bb9d694
Compare
Base automatically changed from
fix-eof-data-section-size-validation
to
develop
December 19, 2024 17:25
cameel
force-pushed
the
testing-code-generation-errors
branch
from
3966f44 to
43b84f0
Compare
matheusaaguiar
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15611.Merged.Depends on #15667.Merged.The PR makes it possible to create Yul syntax tests that cover code generation errors. We only had one such error until now (access to an uninitialized immutable), but with EOF they will be much more common due to the limits imposed by the format that cannot be checked before bytecode generation. Treating those as ICEs is not acceptable. They must be properly reported to the user as errors and also covered with tests.
In this PR I'm making Yul syntax tests not stop after parsing but actually proceed with optimization and assembling. We already do the same thing in Solidity syntax tests.
The PR then adds code generation errors and tests for two EOF cases to make sure the new mechanism works properly.