Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTChecker: Add command-line test for Eldarica #14965

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

blishko
Copy link
Contributor

@blishko blishko commented Mar 25, 2024

This adds a very basic test to verify that Eldarica can be used as the CHC backend.

Depends on #14964.

@blishko blishko marked this pull request as ready for review March 25, 2024 15:27
@r0qs r0qs added has dependencies The PR depends on other PRs that must be merged first smt labels Mar 25, 2024
@r0qs r0qs force-pushed the bump-docker-images branch from 0bdc829 to 0484906 Compare March 25, 2024 19:37
@r0qs r0qs force-pushed the bump-docker-images branch from 0484906 to e99cb73 Compare March 26, 2024 11:02
@r0qs r0qs force-pushed the bump-docker-images branch from e99cb73 to 504de39 Compare March 26, 2024 11:12
@r0qs r0qs force-pushed the bump-docker-images branch from 504de39 to b5e9474 Compare March 26, 2024 11:57
@r0qs r0qs force-pushed the bump-docker-images branch from b5e9474 to cff7d16 Compare March 26, 2024 12:48
@r0qs r0qs force-pushed the bump-docker-images branch from cff7d16 to 837e394 Compare March 26, 2024 13:15
@r0qs r0qs force-pushed the bump-docker-images branch from 837e394 to b3df51a Compare March 26, 2024 14:53
@r0qs r0qs force-pushed the bump-docker-images branch from b3df51a to d8914de Compare March 26, 2024 14:58
@r0qs r0qs force-pushed the bump-docker-images branch from d8914de to c1f6119 Compare March 26, 2024 15:07
@r0qs r0qs requested a review from cameel March 26, 2024 16:08
r0qs
r0qs previously approved these changes Mar 26, 2024
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I imagine you want to add more tests for eldarica, right? Or will you do it in another subsequent PR?

@blishko
Copy link
Contributor Author

blishko commented Mar 26, 2024

My original idea was to create only a couple of CLI tests. I plan to add tests for computing invariants and counterexamples when I implement that functionality.

But if we have Eldarica available both on Ubuntu and OSX, maybe I can add also some SMTCheckerTests that will target Eldarica specifically. I will have to check if that will be possible.

@r0qs r0qs force-pushed the bump-docker-images branch from c1f6119 to 1fec659 Compare March 27, 2024 15:59
Base automatically changed from bump-docker-images to develop April 2, 2024 13:19
@ekpyron ekpyron dismissed r0qs’s stale review April 2, 2024 13:19

The base branch was changed.

@blishko blishko merged commit 28e91a4 into develop Apr 2, 2024
73 checks passed
@blishko blishko deleted the eldarica-test branch April 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first smt testing 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants