Switch from solcjs to solc.js in external tests
#12582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the breakage we got in external tests after ethereum/solc-js#587 got merged yesterday. For example Colony tests are failing because the script is now called
solc.jsrather thansolcjs.There's ethereum/solc-js#590 which adds back a symlink for backwards compatibility but the link is not likely to stay there long-term so we should just switch to the new name.
Note that after ethereum/solc-js#566, which is likely to get merged very soon, the script to run will change again (to
dist/solc.js) so another fix will be necessary (and probably an extra command to run TypeScript compilation first).