-
Notifications
You must be signed in to change notification settings - Fork 490
Add the missing common/helpers.ts
to package.json
#623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like "common/types.js" should be added too as it is also imported in linker.ts |
As far as I can see |
Yes you are right, it is not present in the built linker.js file. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but not approving yet since I'd like to play with it a bit tomorrow and also investigate why this does not trigger a failure in CI.
Well, we still need to find out why it went through our tests unnoticed. And then, when we fix the tests, we should rebase all these PRs on top of that to make sure the fix still passes them. I hope that the missing entry in |
common/helpers.ts
to package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there were no other issues. Tests with my fix in #625 now detect this problem and they do pass when rebased on top of this PR. See #625 (comment).
Fixes #622.
I guess this is enough to fix the issue, but maybe better if @cameel and/or @stephensli confirmed.