Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the header_with_proof test vectors after SSZ Union removal #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kdeme
Copy link
Collaborator

@kdeme kdeme commented Jan 24, 2025

No description provided.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran this through our header validation logic and it's able to deserialize and verify the proofs for all of these pre-merge blocks.

@njgheorghita
Copy link
Contributor

LGTM! Confirmed that these works inside trin with our updated types

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: when do you think we can merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants