simulators/portal: update gossip to put content tests #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhartnett
reviewed
Jan 2, 2025
| if nodes_gossiped_to != 1 { | ||
| panic!("We expected to gossip to 1 node instead we gossiped to: {nodes_gossiped_to}"); | ||
| match client_a.rpc.put_content(content_key.clone(), content_offer_value.encode()).await { | ||
| Ok(PutContentInfo { peer_count, .. }) => { |
There was a problem hiding this comment.
Maybe the test should check that the storedLocally flag is true in the response.
There was a problem hiding this comment.
This assumes the radius is 100 percent, which I don't think we can assume
There was a problem hiding this comment.
Yes true. I guess it depends on how the nodes are setup in the tests.
There was a problem hiding this comment.
Maybe in the future we can standardize some startup params around this kind of thing
bhartnett
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tests to match spec ethereum/portal-network-specs#346
@bhartnett for a quick look