Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added eip 7702 schema and authlist in receipt schema #575

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Added eip 7702 schema and authlist in receipt schema #575

wants to merge 13 commits into from

Conversation

Redidacove
Copy link

Motivation
This is for closing #561

As mentioned I have added same eip 1559 + auth list referenced to reciept schema where added authlist definition

lightclient
lightclient reviewed Sep 2, 2024
View reviewed changes
src/schemas/receipt.yaml Outdated Show resolved Hide resolved
src/schemas/receipt.yaml Outdated Show resolved Hide resolved
src/schemas/transaction.yaml Outdated Show resolved Hide resolved
@lightclient
Copy link
Member

Please also add the 7702 tx to TransactionSigned

@PelleKrab
Copy link

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md

The issue originally said 1559 + auth list, but EIP spec now says 4844 instead.

"of the outer transaction follow the same semantics as EIP-4844."

@Redidacove
Copy link
Author

@lightclient can you review this plz hope I fixed your concern

@lightclient lightclient mentioned this pull request Sep 30, 2024
Closed
jochem-brouwer
jochem-brouwer suggested changes Sep 30, 2024
View reviewed changes
src/schemas/transaction.yaml Outdated Show resolved Hide resolved
src/schemas/transaction.yaml Outdated Show resolved Hide resolved
src/schemas/transaction.yaml Outdated Show resolved Hide resolved
@Redidacove
Copy link
Author

I think i messed up the branch with a bad rebase

@Redidacove Redidacove mentioned this pull request Sep 30, 2024
Closed
@Redidacove
Copy link
Author

Plz move the conversation to #592

@Redidacove Redidacove closed this Sep 30, 2024
@lightclient lightclient reopened this Sep 30, 2024
@lightclient
Copy link
Member

Please fix the branch here instead of opening a separate PR. It's important to keep the conversation around the change in the same thread.

@Redidacove
Copy link
Author

Redidacove commented Sep 30, 2024 •
edited
Loading

@lightclient resolved the issue thnks for the feedback and srry for skipping the issue and opening the new one

emlautarom1
emlautarom1 reviewed Oct 8, 2024
View reviewed changes
Copy link

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At Nethermind we just merged support for 7702 (NethermindEth/nethermind#7459) and we're currently extending our test suite. I have a couple of questions regarding this spec update and I would appreciate if you could take a look at them

src/schemas/transaction.yaml Outdated Show resolved Hide resolved
src/schemas/transaction.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PelleKrab PelleKrab PelleKrab approved these changes

@emlautarom1 emlautarom1 emlautarom1 left review comments

@jochem-brouwer jochem-brouwer jochem-brouwer requested changes

@mattsse mattsse mattsse approved these changes

@lightclient lightclient Awaiting requested review from lightclient

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Redidacove @lightclient @PelleKrab @mattsse @jochem-brouwer @emlautarom1