Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect hex EIP-191 regex length #421

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: incorrect hex EIP-191 regex length #421

merged 1 commit into from
Jul 5, 2023

Conversation

IdrisHanafi
Copy link
Contributor

Reasoning

65 bytes is represented as a 130 character hex, not 65 characters.

Changelog

Before:
Screenshot 2023-06-13 at 9 50 08 PM

After:
Screenshot 2023-06-13 at 9 49 05 PM

lightclient
lightclient approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Thanks for this.

@lightclient lightclient merged commit c009a52 into ethereum:main Jul 5, 2023
2 checks passed
@IdrisHanafi IdrisHanafi deleted the fix/correct-eip-191-regex-length branch July 10, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IdrisHanafi @lightclient