Make tracing feature optional

ethereum · Jul 13, 2018 · fad5203 · fad5203
1 parent 3c737a5
commit fad5203
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/include/evmc/evmc.h b/include/evmc/evmc.h
@@ -780,7 +780,11 @@ struct evmc_instance
     /** Pointer to function executing a code by the EVM instance. */
     evmc_execute_fn execute;
 
-    /** Pointer to function setting the EVM instruction tracer. */
+    /**
+     * Optional pointer to function setting the EVM instruction tracer.
+     *
+     * If the EVM does not support this feature the pointer can be NULL.
+     */
     evmc_set_tracer_fn set_tracer;
 
     /**

diff --git a/test/vmtester/tests.cpp b/test/vmtester/tests.cpp
@@ -67,6 +67,6 @@ TEST_F(evmc_vm_test, set_tracer)
     static constexpr auto tracer_callback = [](evmc_tracer_context*, int, size_t, evmc_status_code,
                                                int64_t, size_t, const evmc_uint256be*, size_t,
                                                size_t, size_t, const uint8_t*) noexcept {};
-    ASSERT_NE(vm->set_tracer, nullptr);
-    vm->set_tracer(vm, tracer_callback, nullptr);
+    if (vm->set_tracer)
+        vm->set_tracer(vm, tracer_callback, nullptr);
 }