check to prevent wallet created with more _required than _owners #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,7 @@ contract multiowned { | |||
| // constructor is given number of sigs required to do protected "onlymanyowners" transactions | |||
| // as well as the selection of addresses capable of confirming them. | |||
| function multiowned(address[] _owners, uint _required) { | |||
| if (_required > 1 && _owners.length < _required -1) throw; | |||
There was a problem hiding this comment.
@sunny-g I believe the -1 is because _owners does not include the msg.sender which automatically becomes an owner as well. so if _owners.length is 2 then _required can be 3 (2 owners provided + the msg.sender creating the contract).
The code should be updated to make this clearer, through comments or by doing a +1 to the owners instead.
There was a problem hiding this comment.
Wow that was dumb misread. My mistake!
There was a problem hiding this comment.
If we do such checks, we should probably also check for:
if (_required == 0) throw;
Also rewriting the current condition as if (_required > _owners.length + 1) would be more readable, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.