This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Chore/makefile #170
Closed
Chore/makefile #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 9, 2018 00:10
|
Sharding in this PR because this waiting on sharding PR to merge? Changes to makefile look good |
|
just saw your note. Reviewing #169 now |
added 6 commits
February 15, 2018 21:55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after: #169
Minor changes here. Just updating the makefile with more general commands, so all the protocols can be used.
Didn't keep the old commands, b/c backwards compatibility sucks (and it seems like a minimally annoying breaking change :) )