This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
fix issue #5598 misleading output on import #5878
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
aleth/aleth/main.cpp
Line 832 in 2fe1bec
always return zero number of synced blocks. It happens because BlockQueue::drain can take m_lock (and it always does) before BlockQueue::verifierBody. So
aleth/libethereum/BlockQueue.cpp
Line 426 in 2fe1bec
tries to extract from empty m_verified queue. The solution is to wait until all unverified blocks gone and then sync