Important fixes in hevm equivalence #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper handling of initial state so that it is not threaded
Previously the state was treaded between rewrites, which is not the correct semantics of Act. Now the left hand side of all rewrites uses the initial state, as opposed to the intermediate.
Keep track of caller so that it can be used when the
The
ActMmonad now keeps track of the symbolic address of the caller, so that theCALLERvariable is implemented correctly.Implementation of
Thiscontext variableThisis no longer a TODO.AMM example in hevm test
This currently times out (under investigation), but trying to fix this example lead to the above fixes.