Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7549: Move to Last Call #9317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update EIP-7549: Move to Last Call #9317

wants to merge 4 commits into from
+46 −2

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented Feb 4, 2025 •
edited
Loading

  • adds complexity analysis
  • explains why Bitvector is used for committee_bits
  • Last call

@mkalinin mkalinin requested a review from eth-bot as a code owner February 4, 2025 07:21
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Feb 4, 2025
octavio12345300
octavio12345300 approved these changes Feb 4, 2025
View reviewed changes
Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list

@Issalk
Copy link

Issalk commented Feb 4, 2025

list

@mkalinin mkalinin closed this Feb 5, 2025
@mkalinin mkalinin reopened this Feb 5, 2025
@github-actions github-actions bot added c-status Changes a proposal's status and removed c-update Modifies an existing proposal s-review This EIP is in Review labels Feb 7, 2025
@mkalinin mkalinin changed the title Update EIP-7549: provide detailed complexity analysis Update EIP-7549: provide detailed complexity analysis, last call Feb 7, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 7, 2025 •
edited
Loading

File EIPS/eip-7549.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

@eth-bot eth-bot added the a-review Waiting on author to review label Feb 7, 2025
@eth-bot eth-bot changed the title Update EIP-7549: provide detailed complexity analysis, last call Update EIP-7549: Move to Last Call Feb 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

The commit d887f42 (as a parent of 9e70d1c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 7, 2025
@timbeiko timbeiko mentioned this pull request Feb 7, 2025
Open
12 tasks
octavio12345300
octavio12345300 approved these changes Feb 8, 2025
View reviewed changes
Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIST

dapplion
dapplion approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@dapplion dapplion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is correct and aligned with the current EIP. Thank you @mkalinin for your contributions to this EIP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@octavio12345300 octavio12345300 octavio12345300 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
a-review Waiting on author to review c-status Changes a proposal's status t-core w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkalinin @Issalk @eth-bot @dapplion @octavio12345300