Enable Module Template #624
Open
+232
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage .find() method Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
…EnableDeputyPauseModuleTemplate Signed-off-by: Elliot <[email protected]>
… module code length is non zero in setup, working functions against testnet, add check state logic for correct slots being written to Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
blmalone
reviewed
Feb 20, 2025
blmalone
reviewed
Feb 20, 2025
…ion, make checkStateDiff view again Signed-off-by: Elliot <[email protected]>
… import DeputyGuardianModule interface, stop overridding checkStateDiff Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
…s-io/superchain-ops into feat/enable-module-template
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
prat-gpt
reviewed
Feb 21, 2025
| } | ||
|
|
||
| /// @notice Validates that the module was enabled correctly | ||
| /// @param chainId The ID of the L2 chain to validate |
This was referenced Feb 21, 2025
Open
blmalone
reviewed
Feb 21, 2025
| @@ -48,7 +48,7 @@ contract MockMultisigTask is MultisigTask { | |||
| } | |||
There was a problem hiding this comment.
The build is failing here, we need this import: import {VmSafe} from "forge-std/Vm.sol";
blmalone
reviewed
Feb 21, 2025
|
|
||
| address[] memory uniqueWrites = accountAccess.getUniqueWrites(); | ||
| assertEq(uniqueWrites.length, 1, "should only write to foundation ops safe"); | ||
| assertEq(uniqueWrites[0], parentMultisig, "should only write to foundation ops safe address"); |
There was a problem hiding this comment.
uniqueWrites[0] is 0xfb1bffC9d739B8D520DaF37dF666da4C687191EA which is the same as the GnosisSafeL2 predeploy: https://github.com/safe-global/safe-smart-account/blob/a1e7f4a763952f5b116a8ab4c7361b95de2083c3/CHANGELOG.md?plain=1#L444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new template to enable modules.
Not currently ready for review.
Should close #621