eth/029: upgrade and re-initialize Base's SystemConfig to v2.3.0 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenoliss
force-pushed
the
bo/eth/add-029
branch
from
4ae1c68 to
efc1ab4
Compare
blmalone
reviewed
Jan 27, 2025
tasks/eth/029-holocene-system-config-upgrade-and-init-base/.env
Outdated
Show resolved
Hide resolved
tasks/eth/029-holocene-system-config-upgrade-and-init-base/.env
Outdated
Show resolved
Hide resolved
tasks/eth/029-holocene-system-config-upgrade-and-init-base/README.md
Outdated
Show resolved
Hide resolved
blmalone
reviewed
Jan 27, 2025
tasks/eth/029-holocene-system-config-upgrade-and-init-base/VALIDATION.md
Outdated
Show resolved
Hide resolved
blmalone
reviewed
Jan 27, 2025
tasks/eth/029-holocene-system-config-upgrade-and-init-base/VALIDATION.md
Outdated
Show resolved
Hide resolved
tasks/eth/029-holocene-system-config-upgrade-and-init-base/VALIDATION.md
Outdated
Show resolved
Hide resolved
|
I have reviewed the changes and it is ready to merge |
JosepBove
previously approved these changes
Jan 28, 2025
blmalone
previously approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Approving. I left one comment which seems to be a typo.
Lets also wait for a review from @JosepBove before merging.
tasks/eth/029-holocene-system-config-upgrade-and-init-base/VALIDATION.md
Outdated
Show resolved
Hide resolved
|
After Blaine's change it looks good. |
JosepBove
previously approved these changes
Jan 29, 2025
blmalone
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Base's
SystemConfigon Mainnet to v2.3.0.Duplicate of #476 with slight modifications for mainnet nested multisig.
Additional context
Base specifics:
checkSystemConfigUpgradeWithPreviousGasLimitOverridetoscript/verification/HoloceneSystemConfigUpgrade.s.solto allow updating thegasLimit.SystemConfigProxy.setEIP1559Params(250,2)call to the end of thetasks/eth/029-holocene-system-config-upgrade-and-init-base/input.jsonviajust add-transaction tasks/eth/029-holocene-system-config-upgrade-and-init-base/input.json 0x73a79Fab69143498Ed3712e519A88a918e1f4072 'setEIP1559Params(uint32,uint32)' 250 2SystemConfigProxy.transferOwnership(SystemConfigOwnercall to the end of thetasks/eth/029-holocene-system-config-upgrade-and-init-base/input.jsonviajust add-transaction tasks/eth/029-holocene-system-config-upgrade-and-init-base/input.json 0x73a79Fab69143498Ed3712e519A88a918e1f4072 'transferOwnership(address)' 0x14536667Cd30e52C0b458BaACcB9faDA7046E056