Simulate non-terminal tasks in CI - @bordolot contribution #420
+140
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blmalone
force-pushed
the
bm/simulate-in-ci
branch
2 times, most recently
from
ca0f674 to
b8f89d4
Compare
blmalone
changed the title
|
I’m glad to hear that! This is my first-ever contribution to any project, and I’m very excited to see it progress. |
|
It seems there might be an issue during the execution of the approve command in the nested.just file. The job simulate_eth_022 might have passed because it does not call this command. |
|
@bordolot I'm going to jump back into looking at this. |
blmalone
force-pushed
the
bm/simulate-in-ci
branch
from
31746ff to
4c78796
Compare
blmalone
force-pushed
the
bm/simulate-in-ci
branch
from
4c78796 to
6862304
Compare
fix: small updates. fix: simulate enabled in ci. fix: removed libs fix: added submodules back in.
blmalone
force-pushed
the
bm/simulate-in-ci
branch
from
a41260f to
288697a
Compare
blmalone
commented
Jan 14, 2025
| at: . | ||
| - run: | ||
| name: Simulate non-terminal tasks | ||
| command: bash ./script/utils/simulate-tasks.sh |
There was a problem hiding this comment.
It might be nice to have this run but always pass for the time being. The idea would be to catch edge cases before allowing it to block people if it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a draft PR that was a good first shot at adding the simulation of non-terminal tasks to CI here.
This PR builds upon that branch, preserving the open source contributors (@bordolot) commits.
Closes: #337