Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opcm review #572

Merged
merged 18 commits into from
Feb 19, 2025
Merged

Opcm review #572

merged 18 commits into from
Feb 19, 2025
+74 −70

Conversation

alcueca
Copy link
Contributor

@alcueca alcueca commented Feb 3, 2025

Description

Review of the OPCM specs, editing them to match the implementation.

This could also be seen as a comparison between the implementation and the specs, revealing where the implementation departed from the specs.

@alcueca alcueca mentioned this pull request Feb 6, 2025
Open
@alcueca alcueca requested review from mds1 and maurelian February 6, 2025 13:57
@alcueca alcueca enabled auto-merge (squash) February 14, 2025 10:36
@ajsutton ajsutton disabled auto-merge February 19, 2025 03:12
@ajsutton ajsutton merged commit 261920c into main Feb 19, 2025
1 check passed
@ajsutton ajsutton deleted the opcm-review branch February 19, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@protolambda protolambda Awaiting requested review from protolambda

@tynes tynes Awaiting requested review from tynes

@ajsutton ajsutton Awaiting requested review from ajsutton

@sebastianst sebastianst Awaiting requested review from sebastianst

@mslipper mslipper Awaiting requested review from mslipper

@mds1 mds1 Awaiting requested review from mds1 mds1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcueca @maurelian @ajsutton