feat: add resend msg feature changes on fmas (#12) #261
+25
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Apr 18, 2025
| If the message is not included within the expiration window, both the message and the underlying action could be considered lost. | ||
| - Likelihood: Medium. Block builders/sequencers are generally controlled by a single entity per chain. | ||
| - **Mitigations:** From a smart contract perspective, little can be done except allowing calls to `validateMessage` within a deposit context to improve censorship resistance. This is currently under discussion [here](https://github.com/ethereum-optimism/specs/issues/520). | ||
| - Potential Impact: High. If the message failure is not related to a time-sensitive operation but is due to the message being incorrect, it could be considered lost. |
There was a problem hiding this comment.
due to the message being incorrect
what do you mean by an "incorrect" message? not sure I am following this failure mode
There was a problem hiding this comment.
You're totally right on pointing this out.
The 3rd FMA was reformulated, with the msg being censored being the main risk: e8fd593
Lmk if that works or if any change is needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
resendMessagefeature covering the expired messages scenario on the FMAs were this issue was mentioned.Metadata
feat: resend message optimism#15300
feat: resend message #259
feat: resend message specs#659