Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move similar functions to common.js #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move similar functions to common.js #1

wants to merge 1 commit into from

Conversation

JRJurman
Copy link
Collaborator

@JRJurman JRJurman commented Mar 5, 2022

Probably don't need this, but if you wanted to make more significant changes, this might be worthwhile

Copy link
Owner

@ethanjurman ethanjurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this abstraction does move functions that are similarly named together, it ultimately makes it harder to work in a single project (you having to open multiple files at once to work on a single page).

I think if we do end up abstracting the code, I'd like it to be in a way that thematically fits the application- like a section for board logic and a section for the letters at the bottom.

I'm gonna mark request changes, but I don't truly think this work is necessary- so don't feel pressured to update it, and feel free to close it.
I might steal the readme part tho- that's an oversight on my part (not including a development section)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants