Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise documentation for Ethereum consensus clients #310

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Karrenbelt
Copy link
Contributor

@Karrenbelt Karrenbelt commented Aug 20, 2024

Refined the documentation for consensus clients to improve readability and consistency. Replaced outdated content with links to official documentation for up-to-date information. Aligns with updates in PR #309 regarding the execution clients section for a uniform presentation.

Please review @ABresting, as I replaced a lot of your previous writing

| [Prysm](https://github.com/prysmaticlabs/prysm) | Go | Prysmatic Labs | Production |
| [Teku](https://github.com/ConsenSys/teku) | Java | ConsenSys | Production |
| [Grandine](https://github.com/grandinetech/grandine) | Rust | Grandine Developers | Production |
| [Caplin](https://github.com/ledgerwatch/erigon) | N/A | Erigon | Development |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should say "Go" under Language for Caplin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course

Copy link
Contributor

@taxmeifyoucan taxmeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's great to have this page cleaned up. I think it's better this way but I would consider adding a bit more info from the original doc


There are multiple Consensus Layer clients developed to participate in the Ethereum Proof-of-Stake (PoS) mechanism. The most popular, FOSS and production ready are [Lighthouse](https://lighthouse-book.sigmaprime.io/), [Lodestar](https://lodestar.chainsafe.io/), [Nimbus](https://nimbus.team/index.html), [Prysm](https://prysmaticlabs.com/) and [Teku](https://consensys.io/teku). These clients are developed in different programming languages, provide have unique features and offer different performance profiles. All clients support Ethereum mainnet out of the box along with active testnets. Variety of implementations allows the network to benefit from client diversity. If you are choosing a client to use, current client diversity should be one of the main factors.
## Overview Table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have a proper table instead of just a text! Still I would provide more context from the deleted paragraph e.g. the part on client diversity

These clients are developed in different programming languages, provide have unique features and offer different performance profiles. All clients support Ethereum mainnet out of the box along with active testnets. Variety of implementations allows the network to benefit from client diversity. If you are choosing a client to use, current client diversity should be one of the main factors.

- [Slashing Protection](https://lighthouse-book.sigmaprime.io/faq.html#what-is-slashing-protection)
- [Doppelganger Protection](https://lighthouse-book.sigmaprime.io/validator-doppelganger.html#doppelganger-protection)
Noteworthy Features:
- [Become a staked Validator](https://lighthouse-book.sigmaprime.io/mainnet-validator.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to be more succinct here but some paragraphs of the original text are still useful. For example I like adding hints for installation, having here fingerprint of gpg key for binaries


### LambdaClass Client
### Caplin and LambdaClass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still split these and provide some context. Caplin is basically usable in production, it is integrated in erigon so it is easiest to setup just by enabling a flag. Lambda also deserves it's own paragraph with links to their repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants