Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore error message for test_eth_getUserOperationReceipt_error #103

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: ignore error message for test_eth_getUserOperationReceipt_error #103

wants to merge 4 commits into from

Conversation

andysim3d
Copy link

No description provided.

drortirosh
drortirosh approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@drortirosh drortirosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there's no need to check error string when it doesn't convey any more info than the error code itself (invalid param)

@drortirosh
Copy link
Contributor

it fails pdm run format --check
please fix so we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drortirosh drortirosh drortirosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysim3d @drortirosh @shahafn