Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the 'calldataCost' from the 'callGasLimit' to 'validationGasLimit' #7

Merged

Conversation

forshtat
Copy link

@forshtat forshtat commented Nov 2, 2023

It is reasonable to assume the "inner" call is the first piece of data known to the transaction sender.
This includes the gas limit needed for the "inner" call to happen. However, the 'calldataCost' also depends on the validation and paymaster data, creating a chicken-or-egg problem.

Moving the costs of caldata to validation defers the calculation of expected calldata cost and allows solving the paradox in most cases.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

It is reasonable to assume the "inner" call is the first piece of data
known to the transaction sender.
This includes the gas limit needed for the "inner" call to happen.
However, the 'calldataCost' also depends on the validation and paymaster
data, creating a chicken-or-egg problem.

Moving the costs of caldata to validation defers the calculation of
expected calldata cost and allows solving the paradox in most cases.
Base automatically changed from unused_gas_penalty_separator_tx to native_account_abstraction November 14, 2023 15:44
@forshtat forshtat merged commit cbb2197 into native_account_abstraction Nov 14, 2023
7 of 13 checks passed
@forshtat forshtat deleted the native_aa_move_calldata_cost_to_validation branch November 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant