Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uenv build: remove timeout in curl::upload #30

Merged
merged 1 commit into from
Dec 11, 2024
Merged

uenv build: remove timeout in curl::upload #30

merged 1 commit into from
Dec 11, 2024

Conversation

simonpintarelli
Copy link
Member

@simonpintarelli simonpintarelli commented Dec 10, 2024 •
edited
Loading

The CI might be slow in responding, remove hardcoded CURLOPT_TIMEOUT, the default is to wait indefinitely:

man CURLOPT_TIMEOUT_MS
CURLOPT_TIMEOUT_MS(3)                              Library Functions Manual                             CURLOPT_TIMEOUT_MS(3)

NAME
       CURLOPT_TIMEOUT_MS - maximum time the transfer is allowed to complete
...
DEFAULT
       0 (zero) which means it never times out during transfer.

Build jobs started running despite timeout, this should help avoid submitting duplicates.

@simonpintarelli simonpintarelli changed the title uenv build: increase connect timeout, remove timeout uenv build: remove timeout in curl::upload Dec 10, 2024
bcumming
bcumming approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcumming bcumming merged commit 8341b85 into main Dec 11, 2024
10 checks passed
@simonpintarelli simonpintarelli deleted the curl-upload-timeout branch December 12, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcumming bcumming bcumming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonpintarelli @bcumming