cleanup rpmbuild #20
Merged
cleanup rpmbuild #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `rpm/make-rpm.sh` did override %set_build_flags macro, although that was not present in rpm/macros.meson
- replace hardcoded C/CXXFLAGS by `%set_build_flags` in `macros.meson` instead
- remove -Wall,-Wpedantic from CXXFLAGS in rpmbuild
- remove `--define "_vpath_srcdir ${source_prefix}"` from `make-rpm.sh`, as far as I can see this macro doesn't exist. The rpm builds successfully without it.
simonpintarelli
force-pushed
the
cleanup-rpm
branch
from
4ae79cc to
88f7cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same PR as #19, but on current main