Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore PYTHONPATH; fix error message when repo not found #32

Merged
merged 2 commits into from
May 31, 2024
Merged

ignore PYTHONPATH; fix error message when repo not found #32

merged 2 commits into from
May 31, 2024

Conversation

bcumming
Copy link
Member

Fix noisy crashes when invalid inputs were entered:

  • an infrequently triggered error when uenv start is run without a default repo had an incorrectly formatted error message.
    • fix and made consistent with the equivalent error message for uenv image commands.
  • if PYTHONPATH was set, incompatible python modules were being picked up
    • launch the commands with env -u PYTHONPATH -u VIRTUAL_ENV

@simonpintarelli simonpintarelli self-requested a review May 31, 2024 14:05
simonpintarelli
simonpintarelli approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@simonpintarelli simonpintarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcumming bcumming merged commit e196151 into master May 31, 2024
6 checks passed
@bcumming bcumming deleted the fix/small branch July 5, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpintarelli simonpintarelli simonpintarelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcumming @simonpintarelli