-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trmm and rocBLAS status code handling to use rocBLAS 3 functionality #1091
Conversation
cscs-ci run |
The test failure is a hang in the hermitian multiplication test again (same as #603 (comment), so not adding it again). I've restarted the job. |
cscs-ci run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
=======================================
Coverage 94.06% 94.06%
=======================================
Files 148 148
Lines 9206 9206
Branches 1166 1166
=======================================
Hits 8660 8660
Misses 324 324
Partials 222 222 ☔ View full report in Codecov by Sentry. |
There's definitely something funky going on with HEMM: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/6128997608#L2341. Already reported on #603, but it might be worth bumping that up the priority list. I'll see if I can reproduce it myself in the next few weeks. |
cscs-ci run |
Uses the out-of-place
rocblas_trmm
whenever available. DefinesROCBLAS_V3
to make the new version of the function available. Still uses the oldrocblas_trmm_outofplace
for older versions. I've only tested compilation on clariden; running still seems to be problematic.Also adds a few
rocblas_status
enumerations that were added in rocBLAS 3.1.0 (ROCm 5.7.0 onwards). I've also updated the rocSOLVERgetErrorString
function to simply forward to the rocBLASgetErrorString
as they should do exactly the same (and were out-of-sync with each other).