Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trmm and rocBLAS status code handling to use rocBLAS 3 functionality #1091

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Feb 1, 2024

Uses the out-of-place rocblas_trmm whenever available. Defines ROCBLAS_V3 to make the new version of the function available. Still uses the old rocblas_trmm_outofplace for older versions. I've only tested compilation on clariden; running still seems to be problematic.

Also adds a few rocblas_status enumerations that were added in rocBLAS 3.1.0 (ROCm 5.7.0 onwards). I've also updated the rocSOLVER getErrorString function to simply forward to the rocBLAS getErrorString as they should do exactly the same (and were out-of-sync with each other).

@msimberg msimberg self-assigned this Feb 1, 2024
@msimberg
Copy link
Collaborator Author

msimberg commented Feb 1, 2024

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Feb 2, 2024

The test failure is a hang in the hermitian multiplication test again (same as #603 (comment), so not adding it again). I've restarted the job.

@msimberg msimberg marked this pull request as ready for review February 5, 2024 19:32
@msimberg
Copy link
Collaborator Author

msimberg commented Feb 8, 2024

cscs-ci run

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0480b65) 94.06% compared to head (e275d58) 94.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         148      148           
  Lines        9206     9206           
  Branches     1166     1166           
=======================================
  Hits         8660     8660           
  Misses        324      324           
  Partials      222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msimberg
Copy link
Collaborator Author

msimberg commented Feb 9, 2024

There's definitely something funky going on with HEMM: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/6128997608#L2341. Already reported on #603, but it might be worth bumping that up the priority list. I'll see if I can reproduce it myself in the next few weeks.

@msimberg msimberg requested review from albestro and RMeli February 12, 2024 10:19
@rasolca
Copy link
Collaborator

rasolca commented Feb 12, 2024

cscs-ci run

@rasolca rasolca merged commit 84f7b2d into master Feb 13, 2024
4 checks passed
@rasolca rasolca deleted the rocblas-v3 branch February 13, 2024 15:32
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants