-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot API 7.4: Stars, effects, etc #2285
Conversation
…ndPhoto, sendVideo, sendAnimation, sendAudio, sendDocument, sendSticker, sendVideoNote, sendVoice, sendLocation, sendVenue, sendContact, sendPoll, sendDice, sendInvoice, sendGame, and sendMediaGroup.
…utMediaAnimation, InputMediaPhoto, InputMediaVideo, InlineQueryResultGif, InlineQueryResultMpeg4Gif, InlineQueryResultPhoto, InlineQueryResultVideo, InlineQueryResultCachedGif, InlineQueryResultCachedMpeg4Gif, InlineQueryResultCachedPhoto, and InlineQueryResultCachedVideo.
…essage, sendPhoto, sendVideo, sendAnimation, sendAudio, sendDocument, sendSticker, sendVideoNote, sendVoice, sendLocation, sendVenue, sendContact, sendPoll, sendDice, sendInvoice, sendGame, and sendMediaGroup.
…ation, sendPhoto, sendVideo, copyMessage, and editMessageCaption.
@Badiboy need your opinion on 2 unchecked points, which are related to provider_token |
I am sort of done on the rest, though not sure on how correct my implementation was; I might have hurried at some points |
Got it, will take a look. |
Dev said passing empty string for provider_token is fine |
I mean, it says omitted, which would mean not passing provider_token |
It says LEFT EMPTY. Not ommited. |
Lol, we read different sources ) |
@coder2020official , could you please clarify, why you used post here? |
I propose to allow users to pass NONE to this parameter (obviously) and add check |
telebot/types.py
Outdated
@@ -4483,6 +4494,8 @@ def to_dict(self): | |||
json_dict['photo_height'] = self.photo_height | |||
if self.description: | |||
json_dict['description'] = self.description | |||
if self.show_caption_above_media: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if self.show_caption_above_media:
to
if self.show_caption_above_media is not None:
Here and everywhere.
Except "post" question and left comment LGTM. |
If we make provider_token optional, backward compatibility will be gone |
I said nothing about "make optional". I said "allow to pass NONE" :) |
So I just change API helper as you said? And adjust the provider_token to Union[str, None]? |
Yep, I don't see other ways. |
@Badiboy I think I'm done |
@coder2020official Release? |
No, there is one issue that needs to be closed before that; |
May 28, 2024
Bot API 7.4