Simplify release permissions process #19450
Merged
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in last two release meetings this pull request simplifies our release permissions process by moving away from manual changes to branch restrictions and instead making the permissions based on membership of the release GitHub team.
Historically for every release we would:
k/org
pr in advance to give release team elevated permissions by changing the permission levels for groups.k/org
pr to revoke release team elevated permissions by changing the permission levels for groups.In future we will instead:
k/org
pr in advance of each release to add release team members to the GitHub teamk/org
pr to revoke release team elevated permissions by removing members from release group.By adding @etcd-io/release-etcd as an entity that can bypass the stable release branch restrictions and just managing the membership of that group we have a simpler, less manual way of carrying out future releases.
cc @ahrtr, @serathius, @ivanvc