Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify release permissions process #19450

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Simplify release permissions process #19450

merged 1 commit into from
Feb 20, 2025

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Feb 19, 2025

As discussed in last two release meetings this pull request simplifies our release permissions process by moving away from manual changes to branch restrictions and instead making the permissions based on membership of the release GitHub team.

Historically for every release we would:

  1. Raise a k/org pr in advance to give release team elevated permissions by changing the permission levels for groups.
  2. Once merged, manually edit our branch restrictions in GitHub so that the release team member running the release script could push the release commit directly to the stable release branch without a pull request.
  3. After release raise a k/org pr to revoke release team elevated permissions by changing the permission levels for groups.

In future we will instead:

  1. Raise a k/org pr in advance of each release to add release team members to the GitHub team
  2. After release raise a k/org pr to revoke release team elevated permissions by removing members from release group.

By adding @etcd-io/release-etcd as an entity that can bypass the stable release branch restrictions and just managing the membership of that group we have a simpler, less manual way of carrying out future releases.

cc @ahrtr, @serathius, @ivanvc

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (ef65923) to head (cf6f4fb).
Report is 2 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19450      +/-   ##
==========================================
- Coverage   68.86%   68.85%   -0.02%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
- Hits        24620    24616       -4     
  Misses       9707     9707              
- Partials     1426     1430       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef65923...cf6f4fb. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jmhbnz.

One less manual step 🎉

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Feb 20, 2025

/retest

@ahrtr ahrtr merged commit a29b97a into etcd-io:main Feb 20, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants