Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3grpc: adds log interceptor unit tests #19448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redwrasse
Copy link
Contributor

@redwrasse redwrasse commented Feb 18, 2025

Adds unit tests for the log interceptorinterceptor.logUnaryRequestStats addressing #16823.

Code coverage has likely evolved since #16823 was opened. The unit tests in this PR try to test a few general properties of the interceptor.logUnaryRequestStats interceptor as well as the case of *pb.TxnResponse type response appearing to be missing coverage (coverage lines referenced in the description for #16823).

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redwrasse
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (deb9178) to head (ffc4bc9).

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/v3rpc/grpc.go 95.12% <100.00%> (ø)
server/etcdserver/api/v3rpc/interceptor.go 90.10% <100.00%> (+12.50%) ⬆️

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19448      +/-   ##
==========================================
+ Coverage   68.90%   69.00%   +0.09%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
+ Hits        24636    24670      +34     
+ Misses       9693     9660      -33     
+ Partials     1424     1423       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb9178...ffc4bc9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants