-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: Remove deprecated NewZapCoreLoggerBuilder #19403
server: Remove deprecated NewZapCoreLoggerBuilder #19403
Conversation
Signed-off-by: Ivan Valdes <[email protected]>
I will add it to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19403 +/- ##
==========================================
- Coverage 68.94% 68.90% -0.05%
==========================================
Files 420 420
Lines 35759 35757 -2
==========================================
- Hits 24655 24637 -18
- Misses 9679 9699 +20
+ Partials 1425 1421 -4 Continue to review full report in Codecov by Sentry.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ahrtr: new pull request created: #19404 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ivan Valdes <[email protected]>
This pull request removes the deprecated
NewZapCoreLoggerBuilder
function.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.