Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Remove deprecated NewZapCoreLoggerBuilder #19403

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 12, 2025

This pull request removes the deprecated NewZapCoreLoggerBuilder function.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 12, 2025

I will add it to the CHANGELOG once the PR is merged.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (dd6791c) to head (8b99f8e).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config_logging.go 52.17% <ø> (+0.64%) ⬆️

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19403      +/-   ##
==========================================
- Coverage   68.94%   68.90%   -0.05%     
==========================================
  Files         420      420              
  Lines       35759    35757       -2     
==========================================
- Hits        24655    24637      -18     
- Misses       9679     9699      +20     
+ Partials     1425     1421       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6791c...8b99f8e. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 12, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 7073c41 into etcd-io:main Feb 12, 2025
38 checks passed
@ahrtr
Copy link
Member

ahrtr commented Feb 12, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19404

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the remove-server-deprecated-new-zap-core-logger-builder branch February 12, 2025 21:48
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants