-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix the output of etcdctl watch -i
#19397
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JalinWang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JalinWang. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
watch -i
etcdctl watch -i
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19397 +/- ##
==========================================
- Coverage 68.94% 68.88% -0.06%
==========================================
Files 420 420
Lines 35759 35764 +5
==========================================
- Hits 24654 24637 -17
- Misses 9684 9705 +21
- Partials 1421 1422 +1 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Jalin Wang <[email protected]>
acdab4d
to
76065c1
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, @JalinWang. Please take a look at my comment :)
@@ -131,7 +131,7 @@ func watchInteractiveFunc(cmd *cobra.Command, osArgs []string, envKey, envRange | |||
cobrautl.ExitWithError(cobrautl.ExitError, err) | |||
} | |||
default: | |||
fmt.Fprintf(os.Stderr, "Invalid command %s (only support watch)\n", l) | |||
fmt.Fprintf(os.Stderr, "Invalid command %s (only support `watch` & `progress`)\n", l) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to suggest having the same message in both places for consistency (and use the opportunity to improve the grammar :). i.e.,
fmt.Fprintf(os.Stderr, "Invalid command %s (only support `watch` & `progress`)\n", l) | |
fmt.Fprintf(os.Stderr, `Invalid command %s (only "watch" and "progress" are supported)\n`, l) |
And apply the same to line 108.
@JalinWang: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Although the interactive mode of
etcdctl watch
supportsprogress
command now, the output is a little bit out-of-date :(