Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: improve coverage upload #19364

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 7, 2025

Align running the code coverage upload with other workflows by executing it from a Makefile target.

Update the current GitHub workflow to call this new target.

I identified this improvement while migrating this workflow to a Prow job.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Align running the code coverage upload with other workflows by
executing it from a Makefile target.

Update the current GitHub workflow to call this new target.

Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/S labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (9de211d) to head (6c86654).
Report is 4 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19364      +/-   ##
==========================================
- Coverage   68.98%   68.84%   -0.14%     
==========================================
  Files         420      420              
  Lines       35739    35739              
==========================================
- Hits        24656    24606      -50     
- Misses       9660     9708      +48     
- Partials     1423     1425       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de211d...6c86654. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit e499f01 into etcd-io:main Feb 10, 2025
39 checks passed
@ivanvc ivanvc deleted the improve-coverage-upload branch February 10, 2025 19:55
@ivanvc
Copy link
Member Author

ivanvc commented Feb 18, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19447

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/S
Development

Successfully merging this pull request may close these issues.

5 participants