Skip to content

Commit

Permalink
Merge pull request #19342 from aladesawe/server-alarm-unexported-return
Browse files Browse the repository at this point in the history
Move interface `AlarmBackend` from `server/etcdserver/api/v3alarm` to `server/storage/schema` to fix the `unexported-return` lint error
  • Loading branch information
ahrtr authored Feb 18, 2025
2 parents 1e3710a + 6f27da2 commit deb9178
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
13 changes: 3 additions & 10 deletions server/etcdserver/api/v3alarm/alarms.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,13 @@ import (
pb "go.etcd.io/etcd/api/v3/etcdserverpb"
"go.etcd.io/etcd/client/pkg/v3/types"
"go.etcd.io/etcd/server/v3/storage/backend"
"go.etcd.io/etcd/server/v3/storage/schema"
)

type BackendGetter interface {
Backend() backend.Backend
}

type AlarmBackend interface {
CreateAlarmBucket()
MustPutAlarm(member *pb.AlarmMember)
MustDeleteAlarm(alarm *pb.AlarmMember)
GetAllAlarms() ([]*pb.AlarmMember, error)
ForceCommit()
}

type alarmSet map[types.ID]*pb.AlarmMember

// AlarmStore persists alarms to the backend.
Expand All @@ -45,10 +38,10 @@ type AlarmStore struct {
mu sync.Mutex
types map[pb.AlarmType]alarmSet

be AlarmBackend
be schema.AlarmBackend
}

func NewAlarmStore(lg *zap.Logger, be AlarmBackend) (*AlarmStore, error) {
func NewAlarmStore(lg *zap.Logger, be schema.AlarmBackend) (*AlarmStore, error) {
if lg == nil {
lg = zap.NewNop()
}
Expand Down
10 changes: 9 additions & 1 deletion server/storage/schema/alarm.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,20 @@ import (
"go.etcd.io/etcd/server/v3/storage/backend"
)

type AlarmBackend interface {
CreateAlarmBucket()
MustPutAlarm(member *etcdserverpb.AlarmMember)
MustDeleteAlarm(alarm *etcdserverpb.AlarmMember)
GetAllAlarms() ([]*etcdserverpb.AlarmMember, error)
ForceCommit()
}

type alarmBackend struct {
lg *zap.Logger
be backend.Backend
}

func NewAlarmBackend(lg *zap.Logger, be backend.Backend) *alarmBackend {
func NewAlarmBackend(lg *zap.Logger, be backend.Backend) AlarmBackend {
return &alarmBackend{
lg: lg,
be: be,
Expand Down

0 comments on commit deb9178

Please sign in to comment.