Convert existing e2e tests from Gingko to e2e framework #61
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abdurrehman107 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @abdurrehman107. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Gaurav Dasson <[email protected]> Signed-off-by: Abdur Rehman <[email protected]>
Signed-off-by: Abdur Rehman <[email protected]>
Signed-off-by: Abdur Rehman <[email protected]>
abdurrehman107
force-pushed
the
abdur-rehman/convert-existing-e2e-test
branch
from
7446ab7 to
66850e3
Compare
|
@ahrtr Can you please review this? This only replicates the default tests. |
|
Please rebase this PR. |
|
closing PR with respect to #62. |
The above adds the default e2e tests written using the e2e framework. These were earlier written in Gingko. The PR creates a Kind Cluster and installs Prometheus, Cert Manager and Controller manager.
The e2e_test.go file is left empty so I can include tests in it. Most of the work done in Gingko earlier has been replicated in the e2e_suite_test.go.
There are a couple things such as displaying logs at the end of each test (AfterAll() in Gingko) which I cannot add in e2e framework until we begin writing the tests. I have a few more tests ready, and we can begin on them once this PR is merged.