Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove gitlab CI and create github CI #10

Merged
merged 13 commits into from
May 17, 2024
Merged

Conversation

bolinocroustibat
Copy link
Member

@bolinocroustibat bolinocroustibat commented Apr 26, 2024

Related issue: #8

@bolinocroustibat
Copy link
Member Author

bolinocroustibat commented Apr 26, 2024

Still to be done: the previous .env file, which was treated as a environment file (and not variables) by GitLab CI, must be managed by GitHub secrets.

Could be useful: https://github.com/marketplace/actions/create-env-file

@bolinocroustibat bolinocroustibat force-pushed the feat/github-ci branch 3 times, most recently from 1879810 to 10193f5 Compare May 7, 2024 04:22
@bolinocroustibat
Copy link
Member Author

@leoguillaume If you know GitHub Actions and secrets, let me know what you think, especially regarding the use of env files in GitHub (not sure on how we should achieve/convert that). Available to talk quickly about it after you have a quick look

@bolinocroustibat bolinocroustibat force-pushed the feat/github-ci branch 2 times, most recently from 26e9726 to c1f6b87 Compare May 7, 2024 09:28
@bolinocroustibat bolinocroustibat force-pushed the dev branch 2 times, most recently from 52909c8 to 1b2d7fe Compare May 7, 2024 10:14
@dtrckd
Copy link
Collaborator

dtrckd commented May 7, 2024

@bolinocroustibat Can we set up the bot to always respond with the "maintenance message" in this PR, so we can prioritize merging it and validating the deployment pipeline (including any tests) before the other PRs are ready to be merged and tested?

@bolinocroustibat bolinocroustibat added the help wanted Extra attention is needed label May 8, 2024
@bolinocroustibat
Copy link
Member Author

bolinocroustibat commented May 8, 2024

@bolinocroustibat Can we set up the bot to always respond with the "maintenance message" in this PR, so we can prioritize merging it and validating the deployment pipeline (including any tests) before the other PRs are ready to be merged and tested?

Sure, but this is a draft PR and not ready to be merged, as I'm not sure on how to manage the env file in the CI/CD workflow file. I would need some help first on that. If you can help this week you can commit on that one, otherwise I would advise to merge the other PRs and continue on GitLab in the meantime.

@bolinocroustibat
Copy link
Member Author

I am wondering, in fact the two pipelines are exactly the same except the env name.
Maybe this CI can be simplified by having just one single file if there is a way to select the environement as the name of the branch. It should be easy. What do you think about it ? @bolinocroustibat

Yes it should be doable indeed, choosing the environment depending on the branch. I'll have a look at that tomorrow

@dtrckd It's done on the same PR. I realized there were a few other stuff not working. Have a look when you have the time.

Copy link
Collaborator

@dtrckd dtrckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build_and_deploy job, in a single file, looks really cleaner and simpler now, good job!

@bolinocroustibat bolinocroustibat merged commit 09871d4 into dev May 17, 2024
1 check passed
@bolinocroustibat bolinocroustibat deleted the feat/github-ci branch May 17, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants