-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove gitlab CI and create github CI #10
Conversation
b701586
to
b37dbe0
Compare
Still to be done: the previous .env file, which was treated as a environment file (and not variables) by GitLab CI, must be managed by GitHub secrets. Could be useful: https://github.com/marketplace/actions/create-env-file |
1879810
to
10193f5
Compare
@leoguillaume If you know GitHub Actions and secrets, let me know what you think, especially regarding the use of env files in GitHub (not sure on how we should achieve/convert that). Available to talk quickly about it after you have a quick look |
26e9726
to
c1f6b87
Compare
52909c8
to
1b2d7fe
Compare
c1f6b87
to
8f58d1e
Compare
@bolinocroustibat Can we set up the bot to always respond with the "maintenance message" in this PR, so we can prioritize merging it and validating the deployment pipeline (including any tests) before the other PRs are ready to be merged and tested? |
Sure, but this is a draft PR and not ready to be merged, as I'm not sure on how to manage the env file in the CI/CD workflow file. I would need some help first on that. If you can help this week you can commit on that one, otherwise I would advise to merge the other PRs and continue on GitLab in the meantime. |
b23369b
to
21b4eaa
Compare
0a9db81
to
2960f88
Compare
2960f88
to
4e63d75
Compare
4e63d75
to
c8ff700
Compare
bf38922
to
b70fb3d
Compare
9cf6f0e
to
4712a3c
Compare
4712a3c
to
7d4702c
Compare
5d4229b
to
f8bb2ef
Compare
# Conflicts: # .github/workflows/prod.yml
f8bb2ef
to
95a474f
Compare
@dtrckd It's done on the same PR. I realized there were a few other stuff not working. Have a look when you have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build_and_deploy job, in a single file, looks really cleaner and simpler now, good job!
5cc3fbe
to
5f43fa9
Compare
Related issue: #8