Skip to content

Commit

Permalink
Use pesy as a dev dependency (#32)
Browse files Browse the repository at this point in the history
See jchavarri/rebez#4

"This is probably due to stale dune files: pesy must have marked dune files as stale after it updated. But the problem can be avoided by using pesy a bit differently.

Pesy is right now caught in between being a build tool and a config manager. It doesn't function to it full potential as a build tool as it doesn't work closely with dune enough (for instance it is forced to create dune files in source). So it's best left to just manage config for you.

This means, we now use pesy only to generated config files for the project (dune and CI). We can now move pesy to devDependencies, thereby ensuring packages that consume rebez don't have to pull pesy."
  • Loading branch information
ManasJayanth authored Jul 12, 2019
1 parent 31632e2 commit d62e38b
Show file tree
Hide file tree
Showing 8 changed files with 59 additions and 38 deletions.
4 changes: 2 additions & 2 deletions assets/pesy-package.template.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@
"dependencies": {
"@opam/dune": "*",
"@esy-ocaml/reason": "*",
"refmterr": "*",
"ocaml": "4.7.x",
"pesy": "*",
"@reason-native/rely": "*"
},
"devDependencies": {
"refmterr": "*",
"pesy": "*",
"@opam/merlin": "*"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion esy.lock/.gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 46 additions & 24 deletions esy.lock/index.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions esy.lock/opam/conf-m4.1/opam

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions esy.lock/opam/conf-which.1/opam

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"ocaml": "4.7.x"
},
"devDependencies": {
"pesy-self": "esy/pesy#75d62cfc",
"refmterr": "*",
"@opam/merlin": "*"
},
Expand Down

0 comments on commit d62e38b

Please sign in to comment.