Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow authenticated users to read aws_link_endpoints #1816

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Allow authenticated users to read aws_link_endpoints #1816

merged 2 commits into from
Jan 3, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Dec 9, 2024 •
edited by jgraettinger
Loading

#1815

Description:

Migration for allowing users to read new from colum from data_planes

Workflow steps:

This column will be consumer by the UI dashboard

Documentation links affected:

N/A

Notes for reviewers:

N/A

This change is Reviewable

@travjenkins travjenkins requested a review from a team December 10, 2024 16:01
@travjenkins travjenkins added the change:planned This is a planned change label Dec 10, 2024
@travjenkins
Copy link
Member Author

travjenkins commented Jan 3, 2025 •
edited
Loading

ran and tested that an authenticated user can access

@travjenkins travjenkins requested a review from psFried January 3, 2025 19:11
psFried
psFried approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travjenkins travjenkins merged commit 44dc0db into master Jan 3, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/feature/expose-aws_link_endpoints branch January 3, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psFried psFried psFried approved these changes

@jgraettinger jgraettinger Awaiting requested review from jgraettinger

Assignees
No one assigned
Labels
change:planned This is a planned change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @psFried