flowctl: build using clang instead of gcc #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to using clang instead of GCC in order to work around a compilation error in one of our dependencies, which is due to a bug in GCC 9. See: rustls/rustls#1967
mdibaiee
approved these changes
Oct 15, 2024
psFried
force-pushed
the
phil/flowctl-fix
branch
from
a7fed69 to
970f56d
Compare
|
Tested this by pushing a change to the workflow yaml to have it build the release binary during a PR build. It worked, so I just removed that commit and will merge without waiting for the current (unnecessary) builds to finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using clang instead of GCC in order to work around a compilation error in one of our dependencies, which is due to a bug in GCC 9. See:
rustls/rustls#1967
Unfortunately, I can't think of a way to test this locally, since there's no way to pull the github runner image. I think we'll just need to merge and try the release again and see whether it works 😬
This change is