Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixed (electrum-dash icon) and Exodus Update #32

Merged
merged 5 commits into from
Feb 28, 2018
Merged

Build fixed (electrum-dash icon) and Exodus Update #32

merged 5 commits into from
Feb 28, 2018

Conversation

emartec
Copy link

@emartec emartec commented Feb 28, 2018

I had a problem with the build. A line related to the electrum-dash icon was not working, and simply removing it fixed it all. The icon is present.

BTW, Electrum-dash execution fail. It says something like "module not found: dns". I'll create an issue.

The command "pyrcc4 electrum-dash/icons.qrc -o electrum-dash/gui/qt/icons_rc.py" failed at compilation
new version 1.45
Build fixed + Exodus update to 1.45
This file was added to fix the time zone issue. But actually it is not working. Remove this usless file override
@estevaocm
Copy link
Owner

Thanks. Electrum-Dash issue is logged in #26

@emartec
Copy link
Author

emartec commented Feb 28, 2018

I don't understand....
How the "failed to execute" issue of electrum-dash is related to the vulnerability issue of issue #26 ?

@estevaocm estevaocm merged commit aea192a into estevaocm:master Feb 28, 2018
@estevaocm
Copy link
Owner

My last comment there was: "Electrum-Dash has been upgraded to solve the reported vulnerability, but is broken for lack of dependencies."

I have not succeeded in compiling the latest Electrum-Dash with Python in Bitkey, and decided not to downgrade due to the security issue. I asked the developer to package the dependencies as the other Electrum variants do, but had no response yet.

@estevaocm
Copy link
Owner

@emartec
Copy link
Author

emartec commented Feb 28, 2018

Ok, good!

@estevaocm
Copy link
Owner

To be honest, I have not invested much time fixing this dependency issue. I could use some help.

@estevaocm
Copy link
Owner

Just found a dependencies package from an older version in another rep. Will make an attempt to compile the new one with it.

@estevaocm
Copy link
Owner

It worked!

@emartec
Copy link
Author

emartec commented Feb 28, 2018

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants