Make httpclient dependency version more specific #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, |
|
After pondering this for a bit, it may be better to set the httpclient version to |
|
This seems reasonable, but I'd prefer to hold off and see if we can just get #113 to work instead. |
summera
force-pushed
the
fix-httpclient-versioning
branch
from
56aaa10 to
7a6fbca
Compare
dougcole
added a commit
that referenced
this pull request
Jun 9, 2015
Make httpclient dependency version more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
The current gemspec locks down httpclient to
2.xversions. This allows httpclient2.6to be used with the current release of rets0.7. httpclient2.6is not compatible with rets0.7(PR to fix that issue coming soon!). To fix the incompatibility in the current rets release, probably want to lock httpclient versions down to2.4.x. You could release this is a patch to0.7.