Skip to content

Add schema for engineering units update #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rerpha
Copy link

@rerpha rerpha commented Jun 20, 2025

Description of Work

(as discussed in last ESS-ISIS streaming catch-up meeting)

Adds a schema for an update of engineering units for a given PV.

Units are optional in this schema as they may not exist for certain types of PVs eg. strings.

We did talk about a generic "metadata" class but it's most efficient just to use this for units.

Issue

None

Developer Checklist

  • If there are new schema in this PR I have added them to the list in README.md
  • If there are breaking changes to a schema, I have used a new file identifier and updated the list in README.md
  • There is some documentation here or in the flat buffer file on the use case for this data, including which component is intended to send the data and/or which is the intended receiver.

Approval Criteria

This PR should not be merged until the ECDC Group Leader (acting or permanent) has given their explicit approval in the comments section.
SCIPP/DRAM should also be consulted on changes which may affect them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant