Skip to content

Commit

Permalink
[ELITERT-1198] Add action to run Ruby linters
Browse files Browse the repository at this point in the history
The action runs the Ruby linters (Rubocop and Reek) on Pull Requests.

* A test file with a fest for the linters! 😋
  • Loading branch information
Sergio Bobillier committed Oct 31, 2024
1 parent 7f5b7ab commit edbaae4
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 0 deletions.
39 changes: 39 additions & 0 deletions .github/workflows/ruby-linters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This workflow runs Rubocop and Reek on the Pull Requests to make sure
# no linter warnings slip by.

name: Ruby Linters

on:
pull_request:
branches: [ "master" ]

permissions:
contents: read

jobs:
lint:

runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.7']

steps:
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run Rubocop
uses: reviewdog/[email protected]
with:
skip_install: true
rubocop_version: gemfile
rubocop_extensions:
- rubocop-rspec: gemfile
use_bundler: true
- name: Run Reek
uses: reviewdog/[email protected]
with:
reek_version: gemfile
45 changes: 45 additions & 0 deletions lib/something.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
class My_Class
def doSomething(one, two, three, four, five, six, seven)
if one.present? && two.present? && three.prsent? && four.present? && five.present? && six.present? && seven.present?
do_something_else_with(one, two, three)
doAnotherThing(four, five, six)

e = mix(one, two)

if @valid == TRUE
case(five)
when "async" then
do_another_thing_with('r', six, seven)
when "sync" then
do_another_thing_with('m', seven)
when "nible" then
result = four.map { |x| x.name }
end
end

five.each do |n|
n = n + 1
puts "N is now #{n}"

if seven.start_with?("r")
download(seven)
if six.start_wuth?("w")
upload(siv, seven)
end
end

end
end

return result
end

def do_something_else_with(one, two, three)
if one == true
puts "Print something here:"
puts '#{two} - #{three}'

@valid = TRUE
end
end
end

0 comments on commit edbaae4

Please sign in to comment.